-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VTOL front transition fixes/enhancements in mission mode #12630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfuhrer
added
bug
Hardware: pixycam2
PixyCam2
Hybrid VTOL 🛩️🚁
Multirotor + Fixedwing!
and removed
Hardware: pixycam2
PixyCam2
labels
Aug 5, 2019
sfuhrer
changed the title
[WIP ] VTOL front transition improvements in mission
[WIP ] VTOL front transition fixes in mission mode
Aug 5, 2019
sfuhrer
changed the title
[WIP ] VTOL front transition fixes in mission mode
[WIP]: VTOL front transition fixes in mission mode
Aug 6, 2019
sfuhrer
changed the title
[WIP]: VTOL front transition fixes in mission mode
VTOL front transition fixes in mission mode
Aug 8, 2019
Flight logs:
|
sfuhrer
changed the title
VTOL front transition fixes in mission mode
VTOL front transition fixes/enhancements in mission mode
Aug 12, 2019
dagar
reviewed
Aug 14, 2019
sfuhrer
force-pushed
the
pr_vtol_front_trans_mission
branch
from
August 14, 2019 15:50
1615787
to
5a84dd0
Compare
…t transition Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
…TOL_TAKEOFF waypoint (and enforce heading) Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@sfuhrer Can you get rid of the unwanted submodule changes which slipped in? |
sfuhrer
force-pushed
the
pr_vtol_front_trans_mission
branch
from
August 19, 2019 07:14
5a84dd0
to
d542e6f
Compare
RomanBapst
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR take up #12455 and #12626 (mission yawing timeout) and should improve the user experience/safety of VTOL forward transitions in mission mode. It only affects both VTOL_TAKEOFF and VTOL_TRANSITION commands.
Issues
Before a VTOL_TRANSITION to fixed-wing, the heading needs to be aligned to the next waypoint, otherwise it won't start transitioning. This is a problem when weather vane (WV) is active, as then the heading is always aligned against the wind. Currently the transition thus does not happen with cross/tail wind.
Mission yawing timeout in mission not working #12626 (mission yawing timeout)
Even with WV disabled, when flying with high cross/tail winds, the aerodynamic passive yaw stability always yaws the VTOL into the wind. If this effect is bigger than the maximum yaw control authority, then yaw setpoints can't be followed. This can then be a problem if a transition is not planned against the wind. In this case, if the vehicle can't reach the transition heading, the mission should be aborted and RTL. The time the vehicle has max time to reach transition heading is set with MIS_YAW_TMT (a negative value disables this timeout). Currently this timeout does not work, so keeps trying indefinitely to reach the heading.
The direction of the front transition at a VTOL_TAKEOFF waypoint (this waypoint is the one that per default gets selected for the first waypoint of a VTOL mission) is currently in an arbitrary direction with weather vane enabled (resp. the heading from takeoff is kept if weather vane is disabled).
Changes
Follow-up issues to solve