stm32 and kinetis adc driver move from ISR (hrt_call_every) to new WQ #12638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
force-pushed
the
pr-adc_wq
branch
2 times, most recently
from
61f7366 to
169fa9c
Compare
|
The other minor changes are to bring stm32 and kinetis into sync so that we can factor out the large common portion next. |
davids5
requested changes
Aug 6, 2019
| } else { | ||
| _to_system_power = orb_advertise(ORB_ID(system_power), &system_power); | ||
| } | ||
| _to_system_power.publish(system_power); | ||
|
|
||
| #endif // BOARD_ADC_USB_CONNECTED | ||
| } | ||
|
|
||
| uint16_t board_adc_sample(unsigned channel) | ||
| { |
There was a problem hiding this comment.
@dagar I think this needs to be re-thought from an atomic point of view.
There was a problem hiding this comment.
Which part? Are you thinking about the conversion per sample or getting multiple samples (+ system_power) gpios together?
dagar
force-pushed
the
pr-adc_wq
branch
3 times, most recently
from
6d00b8d to
29a2d30
Compare
davids5
reviewed
Aug 14, 2019
dagar
changed the title
davids5
previously approved these changes
Aug 15, 2019
|
No change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davids5 Not the bigger ADC cleanup I was hoping for, but here's a simple quick change to at least get the ADC sampling (and system_power floating point work) out of HRT.