Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uORB::Subscription minor API cleanup #12640

Merged
merged 1 commit into from
Aug 6, 2019
Merged

uORB::Subscription minor API cleanup #12640

merged 1 commit into from
Aug 6, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 6, 2019 •
edited
Loading

  • In uORB::Subscription the forceInit() method was combined with the existing subscribe().
  • delete unused last_update()

Broken out of #12123.

julianoes
julianoes reviewed Aug 6, 2019
View reviewed changes
src/modules/uORB/Subscription.cpp

_last_generation = curr_gen - (q_size < curr_gen ? q_size : curr_gen);
if (node != nullptr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already reviewed this somewhere.

@dagar dagar merged commit 8f5b7de into PX4:master Aug 6, 2019
@dagar dagar deleted the pr-uorb_Subscription_cleanup branch August 6, 2019 14:28
@weekly-digest weekly-digest bot mentioned this pull request Aug 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianoes julianoes julianoes left review comments

@bkueng bkueng bkueng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagar @bkueng @julianoes