Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create hovergames airframe #12700

Merged
merged 5 commits into from
Nov 4, 2020
Merged

create hovergames airframe #12700

merged 5 commits into from
Nov 4, 2020

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 14, 2019

No description provided.

@dagar
Copy link
Member Author

dagar commented Aug 14, 2019

Is the Hovergames config locked down or is it going to evolve over time?

@dagar
Copy link
Member Author

dagar commented Aug 15, 2019

#12037

@igalloway
Copy link
Contributor

@dagar the airframe and hardware is locked down. I don't know what the best tuning parameters are to use. Most people that build it i notice it is quite twitchy - are the racing copter parameters still the default?

@TSC21
Copy link
Member

TSC21 commented Oct 15, 2019

@dagar @igalloway are we missing something here?

@stale
Copy link

stale bot commented Jan 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale label Jan 13, 2020
@jarivanewijk
Copy link
Contributor

@dagar, do you have time to help us revive this? HoverGames challenge 2 will start soon and it would be great to have our own airframe.

I believe the settings in this PR were copied from the generic S500 config, which is probably a good starting point. We have been using those settings for a while and they give decent results, though it seems to be very sensitive to vibrations. Note that we just used the S500 settings, we do not actually have an S500 frame. I believe we use almost the same frame as what Holybro now sells as X500.

We may need a little help with tuning, which we have little experience with. However, we have a few guys with different setups that can maybe help with testing. @PetervdPerk-NXP @dk7xe @igalloway (Landon is not on GitHub it seems?)

Most participants will use our drone kit with a 4000-5000mAh 3S or 4S battery, so the tuning has to be appropriate for such setups. However, as more add-on components become available the total weight, weight distribution and vibration levels of the drone may change as well.

@stale stale bot removed the stale label Aug 13, 2020
@jarivanewijk
Copy link
Contributor

@dagar @igalloway - Would it be possible to get this merged in the current state? The current PID tuning values have been used for almost two years without any major issues, I think.

(Only thing that would need to change is the airframe ID, 4016 has already been used for the Holybro PX4 Vision devkit).

@dagar
Copy link
Member Author

dagar commented Oct 8, 2020

@dagar @igalloway - Would it be possible to get this merged in the current state? The current PID tuning values have been used for almost two years without any major issues, I think.

(Only thing that would need to change is the airframe ID, 4016 has already been used for the Holybro PX4 Vision devkit).

I'll rebase it.

@dagar dagar marked this pull request as ready for review October 8, 2020 12:58
@dagar dagar force-pushed the pr-hovergames_airframe branch from 81373ce to 8151a9c Compare October 8, 2020 12:58
@dagar
Copy link
Member Author

dagar commented Oct 8, 2020

I've rebased this branch on current master.

@jarivanewijk if you or @igalloway could share one or more representative good logs then I can do a quick pass and incorporate that tuning.

@dagar dagar changed the title [WIP]: create hovergames airframe create hovergames airframe Oct 8, 2020
@igalloway
Copy link
Contributor

Here is a log of my second last flight. The tuning parameters are good
https://logs.px4.io/plot_app?log=83b6a525-f1f3-4947-98c1-9507ec7b801b
Note there is a separate problem with the battery gage that I'm checking - i think there may be a code or parameter problem. The battery may be reporting 100% all the time.

Here's a second log - flight characteristics ok ,but we had some odd problem at the end while hovering before landing
https://logs.px4.io/plot_app?log=f53dabf1-a0fb-433e-8ba8-f09c569db684

@jarivanewijk
Copy link
Contributor

@dagar Are the flight logs provided by @igalloway good enough? Iain mentions some problems, but the flight itself was OK. Do you need any more flight logs to confirm? (Doesn't the flight test team have a HoverGames drone with FMUK66 as well?)

Copy link
Contributor

@igalloway igalloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar
Could you change the code be '4017_nxp_hovergames' and name be 'NXP HoverGames'
After that can we get it merged?
Thanks

Copy link
Contributor

@igalloway igalloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar
Could you change the code be '4017_nxp_hovergames' and name be 'NXP HoverGames'
After that can we get it merged?
Thanks

Copy link
Contributor

@igalloway igalloway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar i updated the two files mentioned. Not sure if we can still use 4017 as the NXP HoverGames drone id?

@dagar dagar force-pushed the pr-hovergames_airframe branch from 83d2f99 to 1870472 Compare November 4, 2020 15:56
@dagar dagar merged commit 03aa2dd into master Nov 4, 2020
@dagar dagar deleted the pr-hovergames_airframe branch November 4, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants