Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKF and AirspeedSelector: publish multiple wind estimate topic instances #12844

Merged
merged 1 commit into from
Sep 1, 2019

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Aug 29, 2019

This PR fixes the publication of multiple wind estimate instances (multiple wind estimates from the airspeed validation module, one from ekf2)

@dagar
Copy link
Member

dagar commented Aug 29, 2019

Would it be worth adding some simple identifier to know where each is originating?

@sfuhrer sfuhrer force-pushed the pr-multiple_wind_estimate_topics branch from 46b869a to 4d9fbea Compare August 29, 2019 14:34
@sfuhrer sfuhrer force-pushed the pr-multiple_wind_estimate_topics branch from 4d9fbea to 4515c55 Compare August 30, 2019 08:02
…ces and log them all

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@sfuhrer sfuhrer force-pushed the pr-multiple_wind_estimate_topics branch from 4515c55 to 098d71f Compare August 30, 2019 08:06
@sfuhrer
Copy link
Contributor Author

sfuhrer commented Aug 30, 2019

Would it be worth adding some simple identifier to know where each is originating?

@dagar Would be useful I guess, yes. If you know your way around it's also possible now (e.g. the EKF wind has a scale of 0).
Do you mean adding an integer as identifier? E.g. 0=EKF wind, 1=beta fused only, 2= with data from airspeed sensor 1, 3=from sensor 2, ..

@sfuhrer sfuhrer marked this pull request as ready for review August 30, 2019 10:52
@sfuhrer sfuhrer self-assigned this Aug 30, 2019
@dagar
Copy link
Member

dagar commented Sep 1, 2019

Yes, although the bigger question is which to actually use in a controller or even to send to the ground over mavlink.

@dagar dagar merged commit ff6577c into master Sep 1, 2019
@dagar dagar deleted the pr-multiple_wind_estimate_topics branch September 1, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants