Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanups - remove non-used pca8574 and oraled drivers #12892

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

BazookaJoe1900
Copy link
Member

Describe problem solved by the proposed pull request
Both led drivers (pca8574 and oraled) are not used, but keep being compiled on many boards.
there is no pca8574 and oraled start on any rcS.
removed as discussed on #12832

Test data / coverage
none done by me....

@dagar
Copy link
Member

dagar commented Sep 4, 2019

Can you delete the actual driver code?

@BazookaJoe1900
Copy link
Member Author

@dagar @LorenzMeier. I can delete it completely, but are you 100% sure that nobody uses it?
users might use it with non-upstream code, or call it by rc.extra, or call by runtime....

@dagar
Copy link
Member

dagar commented Sep 4, 2019

Yes for the same reasons mentioned in #12832.
If there's value in keeping any of these things we can resurrect them with some minimal real testing, but based on the state of this code I don't see any real users. Keeping anything in tree without compiling is even worse.

@BazookaJoe1900 BazookaJoe1900 force-pushed the pr-remove_nonused_light_drivers branch from 453e47e to 4e43ef8 Compare September 4, 2019 10:49
@BazookaJoe1900
Copy link
Member Author

Yes for the same reasons mentioned in #12832.
If there's value in keeping any of these things we can resurrect them with some minimal real testing, but based on the state of this code I don't see any real users. Keeping anything in tree without compiling is even worse.

Done

@dagar dagar merged commit 6ab5c21 into PX4:master Sep 4, 2019
@BazookaJoe1900 BazookaJoe1900 deleted the pr-remove_nonused_light_drivers branch September 4, 2019 18:24
@BazookaJoe1900
Copy link
Member Author

refs to #12409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants