Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTOL attitude controller: fix pusher support in hover #12908

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Sep 5, 2019

Pusher assist in position control is broken currently. Reason for it is that _pusher_throttle is only updated every time https://github.com/PX4/Firmware/blob/69475a172bf743fb4b735d5e5595d8a23f2dba66/src/modules/vtol_att_control/vtol_att_control_main.cpp#L420 is executed, and otherwise _pusher_throttle=0 is set. And update_mc_state is only updated when mc_virtual_attitude_sp is updated.

Also reproducable in SITL (unsteady actuator_controls(3), see below)

…sp changed, such that pusher support in hover works again

Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
@sfuhrer sfuhrer force-pushed the pr-fix_VTOL_pusher_support branch from c29948a to 4b619c5 Compare September 6, 2019 17:16
@sfuhrer
Copy link
Contributor Author

sfuhrer commented Sep 6, 2019

Test flown with standard VTOL, works well.
https://review.px4.io/plot_app?log=39810ece-53c9-4137-9fb8-617a519781de

@sfuhrer sfuhrer added Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing! bug labels Sep 6, 2019
@sfuhrer sfuhrer marked this pull request as ready for review September 6, 2019 17:20
@sfuhrer sfuhrer requested a review from dagar September 6, 2019 17:20
@RomanBapst
Copy link
Contributor

@dagar @sfuhrer Me and Silvan agreed that this part needs to be re-implemented cleanly, e.g. update_vtol_state() should be a pure state machine and not involve setting any variables like the pusher throttle.
I will merge this as it's tested and the current state is broken.

@RomanBapst RomanBapst self-requested a review September 10, 2019 11:52
@RomanBapst RomanBapst merged commit 92b824e into master Sep 10, 2019
@RomanBapst RomanBapst deleted the pr-fix_VTOL_pusher_support branch September 10, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hybrid VTOL 🛩️🚁 Multirotor + Fixedwing!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants