Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollisionPrevention add more distance_sensor orientations #12940

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

dagar
Copy link
Member

@dagar dagar commented Sep 10, 2019

Expand distance_sensor to include orientations every 45 degrees yaw.

The naming is starting to get a bit messy. Suggestions?
One option would be to only have the minimum set as enums in distance_sensor and instead handle these as custom with enums at the param metadata level.

@jkflying
Copy link
Contributor

This certainly makes setting up an 8-sensor system easier.

Is there a hypothetical sensor we could connect 8 of to a single flight controller, that has roughly 45 degree FOV?

@TSC21
Copy link
Member

TSC21 commented Sep 11, 2019

IMHO this will only make sense if we make the drivers capable of connecting multiple sensors of the same type in the same bus - #12864. Otherwise, it's just adding unusable code.

@mcsauder
Copy link
Contributor

mcsauder commented Sep 12, 2019

This certainly makes setting up an 8-sensor system easier.

Is there a hypothetical sensor we could connect 8 of to a single flight controller, that has roughly 45 degree FOV?

@jkflying , you can do this with an mb12xx or a mappydot+ right now.
Edit: you could use 12.

@dagar dagar force-pushed the pr-collision_orientations branch from 4b60b86 to cea403a Compare October 1, 2019 15:47
@dagar dagar changed the title WIP: CollisionPrevention add more distance_sensor orientations CollisionPrevention add more distance_sensor orientations Oct 1, 2019
@mhkabir mhkabir marked this pull request as ready for review October 1, 2019 15:48
@dagar
Copy link
Member Author

dagar commented Oct 1, 2019

This certainly makes setting up an 8-sensor system easier.

Is there a hypothetical sensor we could connect 8 of to a single flight controller, that has roughly 45 degree FOV?

Something from https://www.terabee.com/sensors-modules/ perhaps.

IMHO this will only make sense if we make the drivers capable of connecting multiple sensors of the same type in the same bus - #12864. Otherwise, it's just adding unusable code.

I'm working on it. Baby steps.

@dagar dagar merged commit 0fe271b into master Oct 2, 2019
@dagar dagar deleted the pr-collision_orientations branch October 2, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants