Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drivers: set CM8JL65 signal_quality invalid beyond bounds #12951

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

nicovanduijn
Copy link
Contributor

This changes the driver for the CM8JL65 lidar slightly, now populating the signal_quality flag.

It is set to -1 for unknown signal quality if the measurement is within the bounds (with some margin) defined in the datasheet.

It is set to 0 (denoting invalid signal) if the measurement lies outside that range.

This helps a lot with no-GPS take-offs, since the ground estimate initializes properly with the changes from #12950

@dagar
Copy link
Member

dagar commented Sep 13, 2019

We should capture this generically as the default behavior for all distance sensors that don't provide a real quality (most of them?).

The current idea is to push everything we expect PX4 side into PX4Rangefinder (https://github.com/PX4/Firmware/blob/master/src/lib/drivers/rangefinder/PX4Rangefinder.hpp), then try to keep the drivers as simple as possible (raw data acquisition). Example: #12947

@dagar dagar merged commit a26865c into PX4:master Sep 13, 2019
@nicovanduijn nicovanduijn deleted the cm8j65l-quality-fix branch September 14, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants