-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Added STM32H7 support and Durandal #13065
Conversation
Wow, H7, looking forward to it! |
28d2b1d
to
0dae69e
Compare
fefc228
to
3e16126
Compare
@dagar -
@MaEtUgR any updates? |
Isn't the bl_update mainly used on v2 because that's the boards that needs bootloader update. |
I not sure if it is a problem. My thinking was that you can load the default build and do the update. then load the multicoptor. Is that not an ok path? |
Ok makes sense. |
V2 Multicoptor mainly exists to make sure we don't introduce inter-dependencies between modules and vehicle types that would prevent doing these stripped down dedicated configurations. So I'd only worry about bl_update remaining in px4_fmu-v2_default as an upgrade path. |
ae7c519
to
2cd4f5b
Compare
can you change this logs to be an artifact so we can see were is is failing? |
I think it's already showing the error.
I'm taking a closer look. |
62be2d6
to
764f25c
Compare
764f25c
to
4a49ebd
Compare
@bkueng - rebased on master with latest Nuttx with PX4 contrib that fixes the dcache issue. Now the H7 is looking line the hot proc!
|
@PX4/testflights - Please start testing on all FMUs |
Tested on PixRacer V4: Position Mode: Good. - Procedure Notes: Log: https://review.px4.io/plot_app?log=d01c358b-42db-4692-be82-0e50fd268a0f Tested on Pixhawk V4 pro: Position Mode: Good. - Procedure Notes: Log: Tested on NXP V3 |
3c60ddb
to
15cfe3b
Compare
@PX4/testflights - Please test on K66, FMUv5 |
@davids5 How do we look on CAN here? |
@LorenzMeier Staring it soon. Over 64 32 bit registers of new IP to learn. |
Tested on Pixhawk 4 v5 f-450 Flight Card 1 Modes Tested: Procedure: Notes: Logs: https://review.px4.io/plot_app?log=f60541fa-260a-4265-8e73-97878a0febea Flight Card 2 Modes Tested Procedure Armed form QGC. Note: Logs: Flight Card 3 Procedure Note: Logs: Flight Card 4 Logs: |
@mrpollo we should test K66, V4, V2 as well - then we can merge. |
NuttX 8.2 is releasing this weekend. So I will rebase on master Firmware and Update to 8.2 Nuttx. Then we can retest. |
@mhkabir Did you send the heater changes as PR? I must have missed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a review of the main diff trying to ensure there are no regressions for existing boards. I have reviewed the newly added code for Durandal on a high-level for basic logic errors.
c6d9e29
to
538dbcd
Compare
@mhkabir Could you send a PR with the right device ID you used to track for this param? SENS_TEMP_ID |
Tested on NXP_FMUK66_V3Flight Card 1 Modes Tested: Procedure: Notes: Logs: https://review.px4.io/plot_app?log=953c82a8-4f25-4239-87e7-a970ac606f99 Flight Card 2 Modes Tested Procedure Armed form QGC. Observations: When the vehicle was landing, it did not descend vertically, drifted away with the wind and landed the vehicle manually. Logs: https://review.px4.io/plot_app?log=792db7ac-8738-4bdd-8a03-aa6d88b371b3 Flight Card 3 Procedure Note: Logs: https://review.px4.io/plot_app?log=7f174e97-c897-4003-b818-14858acf2817 @davids5 we also tested Flight card 4(Failsafes) but the log did not get stored on the SD card. We have noticed that on some flights, for example, testing Master or Stable some logs don't get stored. |
@LorenzMeier I'm making a PR for sensor ID autodetection. Just setting the ID in the startup script is too prone to the ID getting changed and then the functionality just breaking silently. |
I would factor this out from this though. |
The Sensor & Heater's location is defined by the board's layout. I would tie it to the SPI bus/chip select ID not the sensor type. |
@davids5 the device ID is based on the bus and chip select - what am I missing? Is there a particular way you'd like to see it implemented? @LorenzMeier yes that was the plan - do you want me to make a temporary PR just setting the device ID to the ICM chip in rc.board_defaults? |
@mhkabir I am not clear on the goal so let me know if I am off base Here is what I can tell you. There is the following on the IMU board.
All of the IC's a subject to the heating. So if the ID & ~(CS|SPIBUS) == SPI1 it is heated. |
Is this only on K66 ? |
538dbcd
to
3810365
Compare
@davids5, correct only for the NXP FMUK66 vehicle. |
How to set TRIG_PINS on Durandal? It have no AUX6. |
Hey David |
This is a work in progress
Todos: @bkueng - Updated!
free
output - Done (see uptream https://bitbucket.org/nuttx/nuttx/pull-requests/1068/stm32h7-allocateheap-sram-and-sram1-are/diff)