-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add here2 mag to startup for fmu-v5 #13162
Conversation
Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
if ! icm20948 -X -M -R 6 start | ||
then | ||
# external emulated AK09916 (Here2) is rotated 270 degrees yaw | ||
ak09916 -X -R 6 start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the AK09916 rotated 270 degrees in your particular setup or within the actual Here2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like inside the Here2, I just copied all this from the fmu-v3 init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's kind of horrible depending on if that's specific to the Here2 or the driver implementation. We'll likely have to review this later (especially if someone else starts using an AK09916).
No, although I think it might be time for a more unified system to probe the possible external peripherals. The other option is adding parameters to explicitly enable them. I'm just curious, have you tried UAVCAN on this thing instead of I2C? |
No, not yet. What would again be the advantages in this case against I2C? |
It's more robust and has the potential for updating firmware over CAN as well. My understanding of the Here2 is that this is a fake "AK09916" being presented by the processor in the unit. |
The here2 mag currently gets only started on fmu-v3 (as this is the fmu version that gets sold with the here2. Would be nice to also enable using it on a v5 from my point of view.
Note: one needs to change the connector (from 8 pin to 10 pin) to get it connectable to a Pixhawk4.
With this PR it also starts up on fmu-v5. I've simply copied it from fmu-v3 (https://github.com/PX4/Firmware/blob/803a71928f106ccefb453fc2bdf960fb22a63a89/boards/px4/fmu-v3/init/rc.board_sensors#L69-L74).
@dagar what are your thoughts, is there something against starting it also for v5?