Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix param update in mc_att_control #13206

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Fix param update in mc_att_control #13206

merged 1 commit into from
Oct 16, 2019

Conversation

jlecoeur
Copy link
Contributor

ModuleParams::updateParams() was never called

@jlecoeur
Fix param update in mc_att_control
0b5950d 
ModuleParams::updateParams() was never called
@jlecoeur jlecoeur added the bug label Oct 16, 2019
@jlecoeur jlecoeur requested a review from dagar October 16, 2019 11:45
dagar
dagar approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@dagar dagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just noticed this as well.

@jlecoeur
Copy link
Contributor Author

It is too easy to forget.

Shall we enforce this by:

  • adding a non implemented protected virtual method ModuleParams::parameter_updated()
  • calling parameter_updated() at the end of ModuleParams::updateParams()
    ?

@dagar dagar merged commit 4cc7b13 into master Oct 16, 2019
@dagar dagar deleted the pr-fix_param_update_mc_att_control branch October 16, 2019 12:17
@dagar
Copy link
Member

dagar commented Oct 16, 2019

It is too easy to forget.

Shall we enforce this by:

  • adding a non implemented protected virtual method ModuleParams::parameter_updated()
  • calling parameter_updated() at the end of ModuleParams::updateParams()
    ?

I'm not sure if that quite fits everywhere, but yes I want to make it harder to misuse. ModuleParams handling the orb check and update might be nice as well.

@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar dagar approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlecoeur @dagar