RC Failsafe fix for RFD 868+/900 Modems #13218
Conversation
src/modules/sensors/rc_update.cpp
Outdated
| @@ -228,6 +228,23 @@ RCUpdate::rc_poll(const ParameterHandles ¶meter_handles) | |||
| /* signal is lost or no enough channels */ | |||
| signal_lost = true; | |||
|
|
|||
| //This problem occurs at RC controllers which are use PPM signal on RFD 868+/900 Modems (Maybe it can be also related another types) | |||
|
|
|||
| } else if (rc_input.channel_count == | |||
There was a problem hiding this comment.
You could limit this to PPM as well.
There was a problem hiding this comment.
I haven't personally used it, but that's my understanding.
Doing this directly in the PPM decode might be better.
There was a problem hiding this comment.
I agree, it would be better doing that in the PPM decoder.
There was a problem hiding this comment.
But the change seems quite specific to fix exactly one corner case, therefore I think it's worth it.
There was a problem hiding this comment.
I'm not sure what you mean. It's a corner case that applies to one specific PPM receiver.
There was a problem hiding this comment.
Yes but it's good for that one corner case 😄.
There was a problem hiding this comment.
My take is that this is good for this corner case, and it doesn't cause any harm so it's worthwhile to be merged.
|
@bkueng any objections to get this in? |
|
Actually yes, I don't like this special case that is protocol-specific in the generic code path for RC. |
|
I can't get why we need to add a new logic to identify such a fail. The RC_FAILS_THR and RC_MAP_FAILSAFE parameters shall be sufficient to cover that case. Am I wrong? |
|
@FlavioTonelli if you have it configured correctly, yes. If not, then this can save you. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
RC Failsafe isn't triggered when PPM signal is valid. These changes update Failsafe trigger logic for RC input. RF Modules keep sending valid PPM signal when the RC Transmitter is lost. RF Modules which are in the air send PPM signal with same type when lost the signal from ground.
This makes the check more specific, so it's only active on PPM input.
julianoes
force-pushed
the
bozkurthan-rc-failsafe-fix
branch
from
d009461 to
7f8814e
Compare
|
@bkueng rebased and made specific to PPM, please review again. |
RC Failsafe isn't triggered when PPM signal is valid. These changes
update Failsafe trigger logic for RC input. RF Modules keep sending
valid PPM signal when the RC Transmitter is lost.
RF Modules which are in the air send PPM signal with same type when lost
the signal from ground.
Replacement for #12595.
Fixes #12381.