Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmuk66-v3:Fix hang on SDIO card removal/reinsertion #13440

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

davids5
Copy link
Member

@davids5 davids5 commented Nov 11, 2019

The interrupt driven card detect logic was enabled
but the auto mounter was not. That interrupt was
calling mmcsd_mediachange.

There is a reentrancy issues in the kinetis callback logic.
Toplevel calls mmcsd_mediachange calls SDIO_CALLBACKENABLE
that calls kinetis_callbackenable that calls kinetis_callback
that calls mmcsd_mediachange.

   The interrupt driven card detect logic was enabled
   but the auto mounter was not. That interrupt was
   calling mmcsd_mediachange.

   There is a reentrancy issues in the kinetis callback logic.
   Toplevel calls mmcsd_mediachange calls SDIO_CALLBACKENABLE
   that calls kinetis_callbackenable that calls kinetis_callback
   that calls mmcsd_mediachange.
@davids5
Copy link
Member Author

davids5 commented Nov 11, 2019

@igalloway FYI

@mrpollo mrpollo requested a review from a team November 13, 2019 16:13
@mrpollo
Copy link
Contributor

mrpollo commented Nov 13, 2019

@PX4/testflights Please help test this PR with the basic set of flight cards.

⚠️This is blocking the release. ⚠️

@jorge789
Copy link

jorge789 commented Nov 14, 2019

Tested on NXP_FMUK66_V3

Flight Card 1

Modes Tested:
Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.

Procedure:
Arm and Takeoff in position mode, after flying for approximately one minute, switched to altitude then stabilized mode.
Notes:
No issues were noted, good flight in general.

Logs: https://review.px4.io/plot_app?log=8ea6860d-a081-4a1b-a0e8-ce275172b28f

Flight Card 3
Modes Tested
Position Mode: Good.
Mission Plan Mode (Automated): Good.
RTL (Return To Land):

Procedure
Arm and Takeoff in position mode, after flying for approximately one minute, switched to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoint see landing behavior.
Good flight in general.

Note:
No issues were noted, good flight in general.

Logs: https://review.px4.io/plot_app?log=d3a58757-df7c-4ca9-8828-32b3d3c0bf74

Flight Card 4
Modes Tested
Fail-safe: The radio control turned off and the vehicle returned and landed correctly.
Note: When the vehicle was landing, it did not descend vertically, drifted away with the wind and landed the vehicle manually

Logs: https://review.px4.io/plot_app?log=d936bd92-64b9-4657-b3a5-242598607fd2

@dagar dagar merged commit 1128771 into master Nov 15, 2019
@dagar dagar deleted the master_k66_sdio_hang branch November 15, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants