Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] icm42670p driver support #18141

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

ShiauweiZhao
Copy link
Contributor

@ShiauweiZhao ShiauweiZhao commented Aug 24, 2021

No description provided.

src/drivers/drv_sensor.h Outdated Show resolved Hide resolved
@dagar
Copy link
Member

dagar commented Aug 25, 2021

Looks good, has this had any testing on hardware?

@ShiauweiZhao
Copy link
Contributor Author

image
image
image
the error_count is fifo_empty becasue i use fifo read imu data
image

@dagar
Copy link
Member

dagar commented Aug 25, 2021

Taking a look at the change I see that you have the output data rate at 800 Hz and the filters set. What we've settled on for the the other drivers is to disable all sensor side processing and get full raw data (or as fast as we possibly need it) via the FIFO and then perform all filtering within PX4. This way you can see what's really happening with the system and the filtering is completely user configurable.

The other setting that's a bit low is the gyro is the gyro range (250 degrees/second).

Would you mind if we sync up the configuration of the icm42670p to be roughly in line with the icm42650 (or similar)?

@ShiauweiZhao
Copy link
Contributor Author

Taking a look at the change I see that you have the output data rate at 800 Hz and the filters set. What we've settled on for the the other drivers is to disable all sensor side processing and get full raw data (or as fast as we possibly need it) via the FIFO and then perform all filtering within PX4. This way you can see what's really happening with the system and the filtering is completely user configurable.

now 42670p use 1.6khz data output and 2000 dps config

@dagar dagar merged commit 686bcff into PX4:master Sep 8, 2021
@mrpollo mrpollo changed the title [feature]icm42670p driver support [feature] icm42670p driver support Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants