Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

px4iofirmware: never directly touch mixer from isr #18147

Merged
merged 3 commits into from
Aug 25, 2021
Merged

px4iofirmware: never directly touch mixer from isr #18147

merged 3 commits into from
Aug 25, 2021

Conversation

dagar
Copy link
Member

@dagar dagar commented Aug 25, 2021 •
edited
Loading

  • mixer and mixer_set_failsafe were actually executing from an ISR

@dagar dagar added the bug label Aug 25, 2021
@dagar dagar force-pushed the pr-px4iofirmware_mixer_load_threading branch from 13cd0f4 to 907cb37 Compare August 25, 2021 16:50
@dagar dagar force-pushed the pr-px4iofirmware_mixer_load_threading branch from 907cb37 to d1cee27 Compare August 25, 2021 17:24
@dagar dagar marked this pull request as ready for review August 25, 2021 17:56
@dagar dagar requested a review from davids5 August 25, 2021 18:42
@LorenzMeier LorenzMeier merged commit c6a6403 into master Aug 25, 2021
@LorenzMeier LorenzMeier deleted the pr-px4iofirmware_mixer_load_threading branch August 25, 2021 19:32
@davids5
Copy link
Member

davids5 commented Aug 25, 2021

@dagar - Still running fine!

@davids5 davids5 mentioned this pull request Sep 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davids5 davids5 davids5 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dagar @davids5 @LorenzMeier