Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT v1.13] Add PX4 vision v1.5 Airframe #20244

Merged
merged 2 commits into from
Sep 20, 2022
Merged

[BACKPORT v1.13] Add PX4 vision v1.5 Airframe #20244

merged 2 commits into from
Sep 20, 2022

Conversation

julianoes
Copy link
Contributor

Backport of #20155.

@julianoes julianoes requested a review from dagar September 19, 2022 10:43
julianoes
julianoes commented Sep 20, 2022
View reviewed changes
boards/cubepilot/cubeorange/test.px4board
@@ -12,3 +12,4 @@ CONFIG_MODULES_TEMPERATURE_COMPENSATION=n
CONFIG_BOARD_TESTING=y
CONFIG_DRIVERS_TEST_PPM=y
CONFIG_SYSTEMCMDS_MICROBENCH=y
CONFIG_SYSTEMCMDS_BL_UPDATE=n
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagar is this ok to save flash for the test platform for the v1.13 backport?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's fine.

@dagar dagar merged commit 8cfc4fc into release/1.13 Sep 20, 2022
@dagar dagar deleted the pr-backport-holybro-vision-1.5 branch September 20, 2022 22:56
@vincentpoont2
Copy link
Member

#19990
image
param set-default SYS_USE_IO 0 was removed here.

I assume it is because SYS_CTRL_ALLOC is enable by default in main FW.
It looks like 1.13.X has SYS_CTRL_ALLOC disable by default, so param set-default SYS_USE_IO 0 is needed due to PX4 vision motors are connected to AUX (FMU PWM OUT).

I am guessing we should put param set-default SYS_USE_IO 0 back to the 1.13 branch? instead of enabling SYS_CTRL_ALLOC on this particular airframe.

@julianoes what do you think?

@julianoes
Copy link
Contributor Author

I think you're right @vincentpoont2. Should we make a PR for that so it can go into v1.13.2 at some point?

@vincentpoont2
Copy link
Member

@julianoes yes, can you please assist on that?

@julianoes
Copy link
Contributor Author

@vincentpoont2 looks like it's there: https://github.com/PX4/PX4-Autopilot/blob/release/1.13/ROMFS/px4fmu_common/init.d/airframes/4016_holybro_px4vision#L21

@julianoes julianoes mentioned this pull request Nov 2, 2022
Merged
@julianoes
Copy link
Contributor Author

Oh, you're right, for v1.5 it's missing.

#20534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaeyoung-Lim Jaeyoung-Lim Jaeyoung-Lim approved these changes

@dagar dagar Awaiting requested review from dagar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julianoes @vincentpoont2 @dagar @Jaeyoung-Lim