netman: update module description #21664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarifies a few key aspects from the module
davids5
reviewed
May 31, 2023
Co-authored-by: David Sidrane <David.Sidrane@Nscdg.com>
Co-authored-by: David Sidrane <David.Sidrane@Nscdg.com>
Co-authored-by: David Sidrane <David.Sidrane@Nscdg.com>
Co-authored-by: David Sidrane <David.Sidrane@Nscdg.com>
|
Hey @davids5, which startup script is responsible for running netman update on boot? |
junwoo091400
added
the
Documentation 📑
davids5
reviewed
Jun 1, 2023
@mrpollo Thanks for updating all this doc. I answered this as "some part of the startup" by providing a link to the start up docs. @junwoo091400 Thanks for tagging some of these with documentation. Historically no one has bothered with that, and so I have not been monitoring. I will do so now that I know you are watching that. I don't have time to look at everything, but very happy to look at things that are relevant. |
it is in rcS line 167 |
mrpollo
added a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: David Sidrane <David.Sidrane@Nscdg.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
dagar
pushed a commit
that referenced
this pull request
Jun 2, 2023
Co-authored-by: David Sidrane <David.Sidrane@Nscdg.com> Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clarifies a few key aspects of the module for our docs here https://docs.px4.io/main/en/modules/modules_system.html#netman
Hey @davids5 it would be good to get your eyes on this one I want to make sure I captured the details correctly, I think the added info will help users.