[Sponsored by CubePilot] stm32h7: Reset USART clock selection #23498
Conversation
This resets the USARTs' clock source selection to the default, in case it has been changed by the bootloader. This is required if booting from the ArduPilot bootloader which happens to reset the clock selection to PLL. Without this fix, UARTs (including the console) is garbled, so presumably at an invalid baudrate.
julianoes
force-pushed
the
pr-fix-usart-clock
branch
from
653d0b9 to
d3f34af
Compare
|
Ignoring failing SITL tests. |
|
@dagar any other boards that we need to include here? |
Anything that potentially ships with the ardupilot bootloader? mRo, etc |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
|
Hey @TOTON95 I think you should implement this fix for all mro/3dr boards since you ship with the Ardupilot bootloader, can you please review if you need it? |
@mrpollo Hey, actually I was checking this specific register with @lgarciaos a few days ago, since we've been having some problems with GPS setup. Going to check on our boards if this solves the issue. Thanks for sharing. 🙌 |
This resets the USARTs' clock source selection to the default, in case it has been changed by the bootloader. This is required if booting from the ArduPilot bootloader which happens to reset the clock selection to PLL. Without this fix, UARTs (including the console) is garbled, so presumably at an invalid baudrate.
This resets the USARTs' clock source selection to the default, in case it has been changed by the bootloader. This is required if booting from the ArduPilot bootloader which happens to reset the clock selection to PLL. Without this fix, UARTs (including the console) is garbled, so presumably at an invalid baudrate.
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
This resets the USARTs' clock source selection to the default, in case it has been changed by the bootloader. This is required if booting from the ArduPilot bootloader which happens to reset the clock selection to PLL. Without this fix, UARTs (including the console) is garbled, so presumably at an invalid baudrate.
This resets the USARTs' clock source selection to the default, in case it has been changed by the bootloader. This is required if booting from the ArduPilot bootloader which happens to reset the clock selection to PLL. Without this fix, UARTs (including the console) is garbled, so presumably at an invalid baudrate.
This resets the USARTs' clock source selection to the default, in case it has been changed by the bootloader.
This is required if booting from the ArduPilot bootloader which happens to reset the clock selection to PLL.
Without this fix, UARTs (including the console) is garbled, so presumably at an invalid baudrate. I suspect this will solve a lot of frustration where serials "just don't work".
I have added defines for Pixhawk 6C and 6X, as well as CubePilot Orange and Orange+. I assume we need to add this to a bunch more boards.
Depends on PX4/NuttX#319.
Needs backporting to v1.14 and v1.15!