-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Helicopter main rotor rpm control #24096
Draft
MaEtUgR
wants to merge
8
commits into
rpm-sensing
Choose a base branch
from
helicopter-rpm-control
base: rpm-sensing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaEtUgR
force-pushed
the
helicopter-rpm-control
branch
from
December 16, 2024 14:40
dd82d45
to
ed0129a
Compare
MaEtUgR
force-pushed
the
helicopter-rpm-control
branch
from
December 16, 2024 17:39
ed0129a
to
317bc0b
Compare
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 1800 byte (0.09 %)]
px4_fmu-v6x [Total VM Diff: 1736 byte (0.09 %)]
Updated: 2024-12-16T17:45:02 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
PX4 currently has no support to control the main rotor's RPM on the autopilot. This should in my eyes be avoided and an ESC with RPM control used if possible but in the following cases that's not so easily possible:
Solution
Following up on #23931 and #24041 we now have the pieces to do a clean helicopter rpm controller for the main rotor.
Changelog Entry
Test coverage
We successfully used the version in the first commit on a real helicopter before it was ported and changed again to clean up and improve for this pull request. We'll follow up with more improvements and new bench tests.
Context
To be added from bench test results.