gimbal: correctly set gimbal_device_id

[julianoes]

When we use a gimbal connected via "RC", so PWM via the Aux channels, we need to set the gimbal_device_id to 1 as per the protocol.

This was missing for GIMBAL_DEVICE_ATTITUDE_STATUS, so I added that, and fixed the name of that variable while at it.

[github-actions]

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 56 byte (0 %)]

    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +56  +0.0%     +56    .text
  +0.0%     +29  +0.0%     +29    [section .text]
  +0.0%     +24  +0.0%     +24    src/modules/mavlink/modules__mavlink_unity.cpp
  +0.6%      +4  +0.6%      +4    ../../src/modules/gimbal/output_rc.cpp
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
  -0.1%      -4  -0.1%      -4    ../../src/modules/gyro_calibration/GyroCalibration.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%    +294  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +55  [ = ]       0    ../../src/modules/camera_feedback/CameraFeedback.cpp
  +0.1%     +42  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +0.1%     +58  [ = ]       0    ../../src/modules/gimbal/output_mavlink.cpp
  +0.1%     +42  [ = ]       0    ../../src/modules/gimbal/output_rc.cpp
  +0.4%     +39  [ = ]       0    msg/topics_sources/gimbal_device_attitude_status.cpp
  +0.1%     +18  [ = ]       0    msg/topics_sources/uORBMessageFieldsGenerated.cpp
  +0.0%     +44  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+0.0%     +42  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.3%     +10  [ = ]       0    ../../src/modules/gimbal/output_rc.cpp
  +0.0%     +52  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  +0.4%      +5  [ = ]       0    task/task_cancelpt.c
+0.0%     +38  [ = ]       0    .debug_loc
  +0.0%      +2  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +0.1%      +2  [ = ]       0    ../../src/modules/gimbal/output_mavlink.cpp
  +0.1%      +2  [ = ]       0    ../../src/modules/gimbal/output_rc.cpp
  +0.0%     +32  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.0%     -17  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  -0.0%      -8  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  -1.5%      -1  [ = ]       0    task/task_cancelpt.c
-0.0%     -21  [ = ]       0    .debug_str
  +1.6%     +46  [ = ]       0    ../../src/modules/camera_feedback/CameraFeedback.cpp
  -0.6%     -31  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  -0.2%      -7  [ = ]       0    ../../src/modules/gimbal/output_mavlink.cpp
  -0.0%     -29  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.3%     -56  [ = ]       0    [Unmapped]
+0.0%    +384  +0.0%     +56    TOTAL

px4_fmu-v6x [Total VM Diff: 48 byte (0 %)]

    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +48  +0.0%     +48    .text
  +0.0%     +24  +0.0%     +24    src/modules/mavlink/modules__mavlink_unity.cpp
  +0.0%     +21  +0.0%     +21    [section .text]
  +0.6%      +4  +0.6%      +4    ../../src/modules/gimbal/output_rc.cpp
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
  -0.1%      -4  -0.1%      -4    ../../src/modules/gyro_calibration/GyroCalibration.cpp
+0.0%     +56  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
-0.0%      -8  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
+0.0%    +294  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  +0.1%     +55  [ = ]       0    ../../src/modules/camera_feedback/CameraFeedback.cpp
  +0.1%     +42  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +0.1%     +58  [ = ]       0    ../../src/modules/gimbal/output_mavlink.cpp
  +0.1%     +42  [ = ]       0    ../../src/modules/gimbal/output_rc.cpp
  +0.4%     +39  [ = ]       0    msg/topics_sources/gimbal_device_attitude_status.cpp
  +0.1%     +18  [ = ]       0    msg/topics_sources/uORBMessageFieldsGenerated.cpp
  +0.0%     +44  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
+0.0%     +34  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  +0.3%     +10  [ = ]       0    ../../src/modules/gimbal/output_rc.cpp
  +0.0%     +52  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  -0.3%      -3  [ = ]       0    task/task_cancelpt.c
+0.0%     +38  [ = ]       0    .debug_loc
  +0.0%      +2  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  +0.1%      +2  [ = ]       0    ../../src/modules/gimbal/output_mavlink.cpp
  +0.1%      +2  [ = ]       0    ../../src/modules/gimbal/output_rc.cpp
  +0.0%     +32  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.0%     -13  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  -0.0%      -8  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
  +4.7%      +3  [ = ]       0    task/task_cancelpt.c
-0.0%     -21  [ = ]       0    .debug_str
  +1.6%     +46  [ = ]       0    ../../src/modules/camera_feedback/CameraFeedback.cpp
  -0.6%     -31  [ = ]       0    ../../src/modules/gimbal/input_mavlink.cpp
  -0.2%      -7  [ = ]       0    ../../src/modules/gimbal/output_mavlink.cpp
  -0.0%     -29  [ = ]       0    src/modules/mavlink/modules__mavlink_unity.cpp
-0.1%     -48  [ = ]       0    [Unmapped]
+0.0%    +380  +0.0%     +48    TOTAL

Updated: 2024-12-18T01:13:51