Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

land_detector: Hotfix to prevent ground contact detection when descen… #6550

Merged
merged 3 commits into from
Feb 13, 2017

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Feb 9, 2017

…ding velocity is very slow with manual stick all the way down

Now the stick down check is only done in manual control and the thrust low is again mandatory to detect ground in any case.

…ding velocity is very slow with manual stick all the way down

Now the stick down check is only done in manual control and the thrust low is again mandatory to detect ground in any case.
Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment needs an update and the if is too complicated to understand. Please split it into some descriptive bools and then do the check.

@MaEtUgR
Copy link
Member Author

MaEtUgR commented Feb 9, 2017

@julianoes Refactoring the whole condition worsened readability in the end...

Copy link
Contributor

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can follow and would say it makes sense.

@LorenzMeier LorenzMeier merged commit 194f0c1 into master Feb 13, 2017
@LorenzMeier LorenzMeier deleted the pr-landdetect-hotfix branch February 13, 2017 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants