Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: AeroFC: Remove unused apps and libs #7993

Merged
merged 1 commit into from
Sep 23, 2017
Merged

Conversation

zehortigoza
Copy link
Contributor

We are running out of flash space in AeroFC so a cleanup is necessary.

Tools not used in Aero RTF, LPE, fixed wing control, vtol control and
unused libs was removed.

before
$ size firmware_nuttx
text data bss dec hex filename
956880 3524 14608 975012 ee0a4 firmware_nuttx

after
$ size firmware_nuttx
text data bss dec hex filename
835560 3508 14616 853684 d06b4 firmware_nuttx

@TSC21
Copy link
Member

TSC21 commented Sep 20, 2017

Is your real intention to remove LPE? So far it is very useful for people working with mocap or with VIO, like my case. If you can, please spare LPE on it :)

@dagar
Copy link
Member

dagar commented Sep 20, 2017

topic_listener is huge and only useful for debugging with a console connected.

We are running out of flash space in AeroFC so a cleanup is necessary.

Tools not used in Aero RTF, INAV, fixed wing control, vtol control and
unused libs was removed.

before
$ size build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx
   text    data     bss     dec     hex filename
 956880    3524   14608  975012   ee0a4 firmware_nuttx

after
$ size build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx
   text    data     bss     dec     hex filename
 832200    3508   14616  850324   cf994 build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx
@zehortigoza
Copy link
Contributor Author

@dagar Thanks for the tip.

@TSC21 ok, for now we have space for both when removing topic listener

old PR
$ size build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx
text data bss dec hex filename
836556 3508 14616 854680 d0a98 build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx

old PR - topic listener
$ size build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx
text data bss dec hex filename
792628 3508 14616 810752 c5f00 build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx

old PR - topic listener + lpe
$ size build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx
text data bss dec hex filename
832200 3508 14616 850324 cf994 build_aerofc-v1_default/src/firmware/nuttx/firmware_nuttx

@dagar
Copy link
Member

dagar commented Sep 20, 2017

That's probably all you can do for now. In the not too distant future we hope to be able to drastically reduce the code in the drivers. A surprisingly large portion of it is duplicated boilerplate.

@dagar
Copy link
Member

dagar commented Sep 21, 2017

Does the aero actually use anything in the px4fmu module?

@zehortigoza
Copy link
Contributor Author

@dagar it use px4fmu to handle RC.

@dagar
Copy link
Member

dagar commented Sep 21, 2017

RC input only? Is the only output handled through tap_esc?

I have a branch that splits RC input and safety button handling out of px4fmu. I'll test and open a PR soon.

@zehortigoza
Copy link
Contributor Author

@dagar exacly. nice let me know when you open this PR so I can test it in AeroFC. Thanks

@dagar dagar merged commit d828068 into PX4:master Sep 23, 2017
@dagar
Copy link
Member

dagar commented Sep 24, 2017

@zehortigoza yet another thing we could do is limit the airframe selection.

@dagar dagar mentioned this pull request Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants