Removed duplicate and fix SRF02 driver #8288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I'm surprised we didn't even have a mechanism to start it. Are there any notable changes to the driver itself? |
|
Not really, the only thing I had to do to make it work was to update the I2C address range and remove the probe() method as it's call in the I2C init() and will fail if the first address is not the right one. |
|
There are a few more differences than I initially saw, but so far it looks fine. Are you able to actually test this? |
|
Yes with a px4pilot (HK) and the srf08 sensor which was the same interface that the srf02 but was a light sensor. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've remove the duplicate SRF02 driver and fix the remaining one.
I've also added a parameter to enable the driver at startup.
The driver functionality has been tested with a pixhawk and the SRF08 sensor (same interface as the SRF02).