Tunes library #8679
Tunes library #8679
Conversation
cmake configs: Modify to include new library
to allign with the libray output which is in us
Now it is possible to set a string and a control. The get_next_tune function use the same return values as the erliaer implemented parse_cmd and parse_string functions.
return -EINVAL
untested on real hardware
- Start tone_alrm driver after uorb
- Replace tone_alarm $TUNE_ERR with tune_control play -m ${TUNE_ERR}
- TUNE_ERR is a string
of the tune to repeat it
|
ran flash, fight a couple calibrations, and booting without sd card on pixracer (V4) only difference I could find from master is the startup tones |
|
flight with pixhawk pro (V4pro) only diference is the tone of startup flight with pixhawk 1 (V2) only diference is the tone of startup |
|
Is the tune at the startup the expected tune? |
|
Overall looks quite good, it's just a lot to go through to verify we haven't lost any functionality. |
|
@r0gelion what is the difference? Is the tune different, or the time it is played? |
|
quick video to show the tones we expect from master and those of this PR: |
|
can you hold off with merging? I might have a few fixes for this branch. Mostly about corner cases. |
|
@santiago3dr thanks a lot for the video. So it seems that the tune sequence gets always played. I personally like that but I leave the decision to @LorenzMeier or @dagar. |
|
@potaito what issues? |
|
Overall the PR looks quite good. We need to do a pass to bring SITL in line, but I don't see any reason we can't merge this now and continue iterating. |
|
Thanks everyone! |
|
@dagar you gave me 5 minutes to reply? 🙃 I'm living on a fork and was not sure what issues are caused by the tunes library itself and what are caused by the (possibly wrong) way I am using it. That's why I was not specific. "Corner cases" I mentioned involve this uninitialized guy for example and repeated tunes not being played back correctly: |
|
@potaito I didn't see anything critical and wanted to get this in before it needed yet another rebase (one of the reasons this has dragged on for months). Let's open a new issue or PR to keep working on any issues. |
|
|
This is a significant cleanup in terms of how we play tunes.