Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PX4 v1.13 MAVLink parachute support #1943
PX4 v1.13 MAVLink parachute support #1943
Changes from all commits
b2f14b4
40f9cbd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasDebrunner @MaEtUgR Can you please check this section.
I've looked at the code in PX4/PX4-Autopilot#18589 and I want to confirm my understanding
The big picture is clear - the
MAV_CMD_DO_PARACHUTE
is emitted if the parachute is detected and healthy on failsafe. TheCOM_PARACHUTE
parameter is checked an will warn if a parachute is expected but not present/healthy.The small picture is less clear:
SYS_STATUS.onboard_control_sensors_present_extended
and.onboard_control_sensors_health_extended
for the recovery system bit. Is that right?onboard_control_sensors_enabled_extended
) - doesn't seem to be set. I would kind have expected enabled to be based on theCOM_PARACHUTE
parameter.COM_PARACHUTE
supposed to do other than be a trigger for sending events when the heartbeat is lost?COM_PARACHUTE
be set for a PWM parachute? In this case how would you know if it is "healthy" etc? Presumably you will still want to emit this info for a GCS?MAV_CMD_DO_PARACHUTE
sent to the specific component that emits the MAV_TYPE_PARACHUTE? What if two are connected? Or is it just sent to current system ID and component 0 (broadcast).MAV_CMD_DO_PARACHUTE
command forwarded? i.e. can a GCS trigger the parachute? Should it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging as this is, I think correct. I still need the detail in ^^^ and that request is tracked in #1977
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used?