Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module breaks Rest schema / Swagger #60

Closed
ericclaeren opened this issue May 17, 2021 · 2 comments
Closed

Module breaks Rest schema / Swagger #60

ericclaeren opened this issue May 17, 2021 · 2 comments

Comments

@ericclaeren
Copy link
Contributor

ericclaeren commented May 17, 2021

After updating to 1.6.0 to fix the previous swagger issue #55 it still seems to break.

After checking: /rest/all/schema?services=all, that returns the follow message"
The "CheckQuoteResultInterface" class doesn't exist and the namespace must be specified. Verify and try again.

I'm getting this issue on Magento 2.3.5-p1 enterprise.

The docs say the following:

Valid object types include a fully qualified class name or a fully qualified interface name.

Cheers, Eric

@ericclaeren
Copy link
Contributor Author

A quick test:

Seems that changing the return type from:
@return CheckQuoteResultInterface

To
@return \Paazl\CheckoutWidget\Api\Data\CheckQuoteResultInterface

Fixes the issue.

Unrelated question, why is the module declaring strict_types while not actually using typehint/return types?

ericclaeren pushed a commit to ericclaeren/magento2-checkout-widget that referenced this issue May 17, 2021
@Frank-Magmodules
Copy link
Collaborator

HI @ericclaeren,
We are happy to share that we've just released the new 1.6.1 version where your PR has been merged.
This indeed fixes the issue, thank you for your contribution to this.
We are closing this issue now but please feel free to reopen the issue if this still occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants