Getting started README #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexphieler
reviewed
Dec 11, 2024
| |------------------------------|----------------------------|---------------------------------------------------------------------------------------|---| | ||
| | /pacsim/steering_setpoint | pacsim::msg::StampedScalar | Target steering angle at the steering wheel/sensor (rad) | YES | | ||
| | /pacsim/torques_max | pacsim::msg::Wheels | Upper bound torque value at each wheel's motor (Nm) | YES | | ||
| | /pacsim/powerground_setpoint | pacsim::msg::StampedScalar | Powered ground multiplier. 0 for no powered aero, 1 for full capacity (Dimensionless) | YES | |
There was a problem hiding this comment.
Please put this in the last row so that related topics are grouped together
There was a problem hiding this comment.
Sorry, I don't fully understand the order in which you want me to put these topics, but I will recommit with a newly sorted one and see if you like it. If you don't like it, let me know.
alexphieler
reviewed
Dec 11, 2024
alexphieler
reviewed
Dec 11, 2024
alexphieler
reviewed
Dec 11, 2024
alexphieler
reviewed
Dec 11, 2024
alexphieler
reviewed
Dec 11, 2024
|
I think it makes sense to have a section for the simulator inputs and outputs each. Could you add that structure to the README and just put a "TBD" placeholder for the outputs?
|
|
Also in the table, could you replace "USED" with "USED WITH DEFAULT MODEL"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a getting_started.md file, that goes into a little bit of detail on topics PacSim subscribes to, what they mean, and regurgitates some other information already present in the main README and the ARWO presentation slides.
If there's anything you'd like me to change, please let me know :>