Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagzygosity should only tag variants carried by affected individuals #13

Merged
merged 8 commits into from
May 3, 2024
Merged

Conversation

williamrowell
Copy link
Contributor

Added a parameter, affected, to tagzygosity. Comma-delimited list of affected individuals. Only affected individuals are considered for tagging.

Needs work before merging. This should probably be an optional input. Also, I deleted all of the large compressed resources because the repo was taking forever to clone. We can revert those changes before merging, but should also consider hosting the files on Zenodo instead.

Opinions on the idea of the change? Any other suggestions?

@williamrowell williamrowell self-assigned this Apr 26, 2024
@williamrowell williamrowell marked this pull request as ready for review May 3, 2024 00:58
svpack Outdated Show resolved Hide resolved
@amwenger
Copy link
Collaborator

amwenger commented May 3, 2024

Added a parameter, affected, to tagzygosity. Comma-delimited list of affected individuals. Only affected individuals are considered for tagging.

I like the idea, and the implementation looks good too. I suggest using a more general parameter name - --samples instead of --affected - since svpack is more general than rare-disease analysis.

Also, I deleted all of the large compressed resources because the repo was taking forever to clone. We can revert those changes before merging, but should also consider hosting the files on Zenodo instead.

Good point. These files are already in https://zenodo.org/records/8415406. Could you update the README.md to reference that Zenodo record and remove the binary files from the repo?

@williamrowell williamrowell requested a review from amwenger May 3, 2024 05:17
@williamrowell williamrowell merged commit 9dddda6 into PacificBiosciences:main May 3, 2024
@williamrowell williamrowell deleted the develop branch May 3, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants