get ubuntu dev environment working per #11 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| /* eslint no-unused-vars: 0 */ | |||
| import utils from './utils'; | |||
| import defaultOptions from './defaultOptions'; | |||
| import MapTable from './MapTable'; | |||
| import MapTable from 'MapTable'; | |||
There was a problem hiding this comment.
Not sure that this would work.
import MapTable from './MapTable'; refers to importing the fiel ./MapTable.js
There was a problem hiding this comment.
if I leave as you have it, I get the error:
➜ maptable git:(dev-7) ✗ gulp
[14:45:47] Using gulpfile ~/Documents/maptable/gulpfile.js
[14:45:47] Starting 'default'...
[14:45:47] Starting 'clean:js:dev'...
[14:45:48] Finished 'clean:js:dev' after 14 ms
[14:45:48] Starting 'build:js:dev'...
[14:45:48] Starting 'build:css:dev'...
[14:45:48] 'build:js:dev' errored after 198 ms
[14:45:48] Error: Could not resolve ./MapTable from /home/mrjones/Documents/maptable/src/index.js
at /home/mrjones/Documents/maptable/node_modules/rollup/dist/rollup.js:7857:37
at tryCatch (/home/mrjones/Documents/maptable/node_modules/rollup/dist/rollup.js:400:12)
at invokeCallback (/home/mrjones/Documents/maptable/node_modules/rollup/dist/rollup.js:412:13)
at publish (/home/mrjones/Documents/maptable/node_modules/rollup/dist/rollup.js:383:7)
at flush (/home/mrjones/Documents/maptable/node_modules/rollup/dist/rollup.js:127:5)
at nextTickCallbackWith0Args (node.js:419:9)
at process._tickCallback (node.js:348:13)
when I change it to MapTable though, I do get this error:
[14:51:07] Starting 'build:css:dev'...
Treating 'MapTable' as external dependency
No name was provided for external module 'MapTable' in options.globals – guessing 'MapTable'
which may also be bad? you can see #11 for details
|
|
||
|
|
||
| ## Release History | ||
| * Version 1.0.0 ? |
There was a problem hiding this comment.
thanks! i updated the readme.md with that info and as well added a bit of info i thought might be helpful for first time dev like me. lemme know if it's too verbose!
| @@ -445,10 +477,11 @@ You are welcomed to fork the project and make pull requests. | |||
| #### Getting Started | |||
There was a problem hiding this comment.
We should provide the version of node and npm that we use:
Node 4 and npm 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get ubuntu dev environment working per #11