-
Notifications
You must be signed in to change notification settings - Fork 115
fix compute and schedule func of sort and argsoft #1198
Conversation
8677775
to
b3d1a47
Compare
b3d1a47
to
00dccc3
Compare
aa6113f
to
297d270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该直接在op mapper中拆分而不是写decomposer,decomposer主要是当初op mapper模块还未加入时的历史遗留模块。而且decomposer还得注册一个算子
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
在添加算子时,我考虑过这个问题;因为如果希望在 BaseBuilder 中添加一个 TopK,这个算子又不是基础算子的话,拆分逻辑感觉只有 decomposer,目前的几层拆分作用我的理解是:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这PR还有bug,后面提的PR里的cinn-ci-x86-mklcblas-off流水都会挂在test_dce_pass这
本地和登陆 CI 机器均没能复现,提了一个 PR #1221 ,改日志代码后 CI 问题消失,看起来是随机原因导致,后面继续跟进 |
…ddlePaddle#1198)"" This reverts commit 26d67b2.
Fix compute and schedule func of sort and argsoft (first commit in #891) and adding unit tests.
TODO: