Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs api #475

Merged
merged 11 commits into from
Sep 24, 2024
Merged

fix docs api #475

merged 11 commits into from
Sep 24, 2024

Conversation

Xuxuanang
Copy link
Contributor

@Xuxuanang Xuxuanang commented Sep 9, 2024

PR Docs

PaddlePaddle/docs#6870
添加文档缺失中的单测以及转换规则等

PR APIs

torch.amp.autocast
torch.amp.autocast_mode.autocast
torch.channel_shuffle
torch.distributions.Binomial
torch.distributions.ContinuousBernoulli
torch.distributions.Exponential
torch.distributions.MultivariateNormal
torch.distributions.binomial.Binomial
torch.distributions.continuous_bernoulli.ContinuousBernoulli
torch.distributions.multivariate_normal.MultivariateNormal
torch.igamma
torch.igammac
torch.nn.functional.channel_shuffle
torch.special.gammainc
torch.special.gammaincc
torch.distributions.exponential.Exponential

Copy link

paddle-bot bot commented Sep 9, 2024

Thanks for your contribution!

@zhwesky2010
Copy link
Collaborator

  1. CI未成功
  2. 这些API需要改映射文档吗?映射文档对应的修改,文档也链接过来

@paddle-bot paddle-bot bot added the contributor External developers label Sep 11, 2024
Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

)


def _test_case_3():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个记录到excel中

@zhwesky2010
Copy link
Collaborator

infoflow 2024-09-12 17-48-01

这几个单测失败了,本地注意测一下

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Sep 18, 2024

https://xly.bce.baidu.com/paddlepaddle/PaConvert/newipipe/detail/11545285/job/27538585//realTimeLog/478 CI还是有失败,这个能看到吗,其他CI目前有些问题不能触发。PR-CI-GPU-UnitTest可以正常触发,先保证PR-CI-GPU-UnitTest可以正常通过。

2024-09-17 00:05:05 =========================== short test summary info ============================
2024-09-17 00:05:05 failed tests/test_distributions_binomial.py::test_case_2 - assertionerror
2024-09-17 00:05:05 failed tests/test_distributions_continuousbernoulli.py::test_case_2 - asserti...
2024-09-17 00:05:05 failed tests/test_distributions_binomial_binomial.py::test_case_2 - assertion...
2024-09-17 00:05:05 failed tests/test_distributions_continuous_bernoulli_continuousbernoulli.py::test_case_2
2024-09-17 00:05:05 ============================== 4 failed in 1.05s ===============================

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Sep 19, 2024

PR Docs

添加文档缺失中的单测以及转换规则等

PR APIs

torch.amp.autocast
torch.amp.autocast_mode.autocast
torch.channel_shuffle
torch.distributions.Binomial
torch.distributions.ContinuousBernoulli
torch.distributions.Exponential
torch.distributions.MultivariateNormal
torch.distributions.binomial.Binomial
torch.distributions.continuous_bernoulli.ContinuousBernoulli
torch.distributions.multivariate_normal.MultivariateNormal
torch.igamma
torch.igammac
torch.nn.functional.channel_shuffle
torch.special.gammainc
torch.special.gammaincc
torch.distributions.exponential.Exponential

后面注意把文档链接附录过来

@zhwesky2010
Copy link
Collaborator

zhwesky2010 commented Sep 19, 2024

@Xuxuanang 目前在做的工作为何还有新增Matcher?安排的工作是修复存量问题

  1. 有文档无Matcher
  2. 有Matcher无文档
  3. 有文档也有Matcher,但两者不对齐

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Sep 23, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 23, 2024
@zhwesky2010
Copy link
Collaborator

@Xuxuanang 你拉一下最新的再测一下试试,为啥单测总是没有运行通过

@zhwesky2010
Copy link
Collaborator

@Xuxuanang 如果有对应文档,在PR描述里填一下

Copy link
Collaborator

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下个PR改一下

)


def test_case_4():
def _test_case_4():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个问题记录到excel里

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

obj.run(pytorch_code, ["result"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个单侧名字有问题吧,test_e.py?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个貌似不是我新加的,是从最新版paconvert里面拉过来的

@zhwesky2010 zhwesky2010 merged commit 2f020df into PaddlePaddle:master Sep 24, 2024
5 of 8 checks passed
@Xuxuanang Xuxuanang deleted the doc1 branch October 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants