【Hackathon 7th No.36】为 Paddle 代码转换工具新增 API 转换规则（第 3 组） #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
单测未通过，请保证CI通过，CI不通过不予合入： |
|
能否修复下CI看错误，谢谢。 |
…nto hackathon7-part1
…nto hackathon7-part1
zhwesky2010
reviewed
Oct 10, 2024
1、收到，增加例子。 torch.signal.windows.blackman(5, dtype=torch.float32)
paddle.audio.functional.get_window("blackman",5, dtype='float32')pytorch: tensor([-1.4901e-08, 3.4000e-01, 1.0000e+00, 3.4000e-01, -1.4901e-08])
paddle: Tensor(shape=[5], dtype=float32, place=Place(cpu), stop_gradient=True,
[-0.00000001, 0.20077014, 0.84922987, 0.84922987, 0.20077014]) |
那这个不太合理，除非API的实现被论证有Bug，这个需要给一个明确的结论出来，是API有Bug还是转换有Bug。需要逐个排查并且打开check_value。 另外你上面的对应是有问题的，应该是这样： 两者是能对应上的，同时说明 已合入的映射文档也可能是存在Bug的，需要一并修复。 |
之前看代码，paddle的general_cosine和pytorch的运算就不同。 paddle: M, needs_trunc = _extend(M, sym)
fac = paddle.linspace(-math.pi, math.pi, M, dtype=dtype)
w = paddle.zeros((M,), dtype=dtype)
for k in range(len(a)):
w += a[k] * paddle.cos(k * fac)
return _truncate(w, needs_trunc)pytorch: constant = 2 * torch.pi / (M if not sym else M - 1)
k = torch.linspace(start=0,
end=(M - 1) * constant,
steps=M,
dtype=dtype,
layout=layout,
device=device,
requires_grad=requires_grad)
a_i = torch.tensor([(-1) ** i * w for i, w in enumerate(a)], device=device, dtype=dtype, requires_grad=requires_grad)
i = torch.arange(a_i.shape[0], dtype=a_i.dtype, device=a_i.device, requires_grad=a_i.requires_grad)
return (a_i.unsqueeze(-1) * torch.cos(i.unsqueeze(-1) * k)).sum(0)两者调用linspace的参数不同，结果也不同。 |
|
blackman和general_cosine好像没法改，其他的我来改。 |
zhwesky2010
reviewed
Oct 12, 2024
|
@zhwesky2010 改好了，不好意思，粗心大意，给您添麻烦了。2个PR都改了。DOC的pr也改了。 |
zhwesky2010
reviewed
Oct 12, 2024
zhwesky2010
reviewed
Oct 12, 2024
zhwesky2010
reviewed
Oct 15, 2024
zhwesky2010
reviewed
Oct 16, 2024
zhwesky2010
reviewed
Oct 16, 2024
luotao1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
Docs:
PR APIs