Skip to content

Commit

Permalink
Revert "[NPU] refine nan check (#34508)" (#34530)
Browse files Browse the repository at this point in the history
  • Loading branch information
gongweibao authored Aug 2, 2021
1 parent c7cc5ac commit af88699
Showing 1 changed file with 25 additions and 23 deletions.
48 changes: 25 additions & 23 deletions paddle/fluid/operators/collective/c_allreduce_op.h
Original file line number Diff line number Diff line change
Expand Up @@ -123,30 +123,32 @@ class CAllReduceOpCPUKernel : public framework::OpKernel<T> {
#if defined(PADDLE_WITH_ASCEND_CL)
// return true if found_inf_or_nan or return false;
template <typename T>
bool ContainsNan(const framework::ExecutionContext& exe_ctx, aclrtStream stream,
const paddle::framework::Tensor* in) {
bool CheckNumerics(const framework::ExecutionContext& exe_ctx,
aclrtStream stream, const paddle::framework::Tensor* in) {
auto& dev_ctx =
exe_ctx.template device_context<paddle::platform::NPUDeviceContext>();
using Tensor = paddle::framework::Tensor;
Tensor out(in->type());

Tensor mean(in->type());
mean.Resize({1});
mean.mutable_data<T>(dev_ctx.GetPlace());
std::vector<int> axes;
for (int i = 0; i < in->dims().size(); ++i) {
axes.push_back(i);
out.Resize(in->dims());
out.mutable_data<T>(dev_ctx.GetPlace());

bool found_inf_data = false;

try {
const auto& runner =
NpuOpRunner("CheckNumerics", {*in}, {out},
{{"message", std::string("check_numberics")}});
runner.Run(stream);
dev_ctx.Wait();
} catch (platform::EnforceNotMet& exception) {
LOG(WARNING) << "[check_nan_and_inf] detected contains NaN or INF!!!";
found_inf_data = true;
} catch (...) {
LOG(WARNING) << "[check_nan_and_inf] detected contains NaN or INF!!!";
found_inf_data = true;
}
const auto& runner_mean = NpuOpRunner("ReduceMeanD", {*in}, {mean},
{{"axes", axes}, {"keep_dims", false}});

std::vector<T> vec;
TensorToVector(mean, exe_ctx.device_context(), &vec);

if (std::isnan(static_cast<float>(vec[0]))) {
return true;
}
return false;
return found_inf_data;
}
#endif

Expand Down Expand Up @@ -214,22 +216,22 @@ class CAllReduceOpASCENDKernel : public framework::OpKernel<T> {
framework::Tensor tmp;
tmp.mutable_data<float>({8}, ctx.GetPlace());

bool has_nan = false;
bool check_numerics = false;

auto d_type = in->type();
switch (d_type) {
case framework::proto::VarType::FP16:
case framework::proto::VarType::FP32: {
VLOG(4) << "prepare to check nan";
has_nan = ContainsNan<T>(ctx, dev_ctx->stream(), in);
VLOG(4) << "ContainsNan:" << has_nan;
VLOG(4) << "prepare to FoundNanInf";
check_numerics = CheckNumerics<T>(ctx, dev_ctx->stream(), in);
VLOG(4) << "check_numerics:" << check_numerics;
break;
}
default:
break;
}

if (has_nan) {
if (check_numerics) {
T inf = static_cast<T>(std::numeric_limits<float>::infinity());
VLOG(4) << "fill input data constant inf";
auto dims = in->dims();
Expand Down

0 comments on commit af88699

Please sign in to comment.