Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a multi-dim add layer test. #10437

Merged
merged 2 commits into from
May 9, 2018
Merged

Conversation

panyx0718
Copy link
Contributor

@panyx0718 panyx0718 commented May 6, 2018

We need to figure out if tensorrt
use row-major or col-major for tensor
layeout inorder to do conversion.

tensorrt doc says its row-major, but in my test, it seems to be col-major

@panyx0718 panyx0718 requested a review from Superjomn May 6, 2018 14:04
@Xreki Xreki added the 预测 原名Inference,包含Capi预测问题等 label May 7, 2018
@panyx0718 panyx0718 requested a review from luotao1 May 7, 2018 09:33
// It seems tensorrt FC use col-major: [[1.0, 3.3], [1.1, 4.4]]
// instead of row-major, which is [[1.0, 1.1], [3.3, 4.4]]
float raw_weight[4] = {1.0, 1.1, 3.3, 4.4};
// [1, 2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请问85行的注释需要删掉或者进行下补充么?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

luotao1
luotao1 previously approved these changes May 8, 2018
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The teamcity fails (fix in #10420), you can merge the latest code.

We need to figure out if tensorrt
use row-major or col-major for tensor
layerout inorder to do conversion.
@panyx0718
Copy link
Contributor Author

This PR is ready @luotao1

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 303277f into PaddlePaddle:develop May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
预测 原名Inference,包含Capi预测问题等
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants