Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean OpProtoAndCheckerMaker #10486

Merged
merged 4 commits into from
May 11, 2018
Merged

Clean OpProtoAndCheckerMaker #10486

merged 4 commits into from
May 11, 2018

Commits on May 8, 2018

  1. Clean OpProtoAndCheckerMaker 

    Do not use ctor

* Reduce line of codes.
* We can use virtual function for Maker now.
* The implementation does not care what maker holds, it is easier to
refactor later.
    @reyoung
    reyoung committed May 8, 2018
    Configuration menu
    Copy the full SHA
    0e78cb6 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2018

  1. Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into… 

    … feature/clean_op_maker
    reyoung committed May 10, 2018
    Configuration menu
    Copy the full SHA
    b0ca371 View commit details
    Browse the repository at this point in the history

  2. Polish Dctor

    @reyoung
    reyoung committed May 10, 2018
    Configuration menu
    Copy the full SHA
    a0c4138 View commit details
    Browse the repository at this point in the history

  3. Fix compile error

    @reyoung
    reyoung committed May 10, 2018
    Configuration menu
    Copy the full SHA
    613d3ef View commit details
    Browse the repository at this point in the history