enable MKLDNN inference test #10701
Merged
enable MKLDNN inference test #10701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
reviewed
May 16, 2018
| for (auto* op : block->AllOps()) { | ||
| if (op->HasAttr("use_mkldnn")) { | ||
| op->SetAttr("use_mkldnn", true); | ||
| } |
There was a problem hiding this comment.
这段代码不适合放在test_helper.h里， @Superjomn 请问放在哪个目录下比较好呢？
There was a problem hiding this comment.
作为目前的inference的测试enable，目前放在这里我觉得是可以的，后期确实可以放到某个API的地方，@Xreki 你觉得呢
There was a problem hiding this comment.
我觉得可以先放在单测里面，验证功能和方便测试。后期肯定需要将这些内容放到paddle代码里面。
There was a problem hiding this comment.
这个函数这里可以加一个comment，说明这个函数以后将会移到Paddle主干代码里面去，临时放在这里为了测试。
Xreki
approved these changes
May 22, 2018
| for (auto* op : block->AllOps()) { | ||
| if (op->HasAttr("use_mkldnn")) { | ||
| op->SetAttr("use_mkldnn", true); | ||
| } |
There was a problem hiding this comment.
这个函数这里可以加一个comment，说明这个函数以后将会移到Paddle主干代码里面去，临时放在这里为了测试。
|
好的，没问题 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable MKLDNN test on AVX
fix C++ part of #10682
Steps to run
Take resnet of image_classification as an example：
make test ARGS="-R test_image_classification -V"to generate the CPU model../build/paddle/fluid/inference/tests/book/test_inference_image_classification_resnet --dirname=./build/python/paddle/fluid/tests/book/image_classification_resnet.inference.model --batch_size=2 --repeat=10 --use_mkldnn=True