Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in DenseScanner of DataProviderConverter. #1121

Merged
merged 1 commit into from
Jan 16, 2017
Merged

Fix bug in DenseScanner of DataProviderConverter. #1121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions paddle/py_paddle/dataprovider_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ def finish_scan(self, argument):


class DenseScanner(IScanner):
"""
:type __mat__: numpy.ndarray
"""

def __init__(self, input_type, pos):
IScanner.__init__(self, input_type, pos)
self.__mat__ = None
Expand All @@ -47,6 +51,8 @@ def scan(self, dat):
def finish_scan(self, argument):
assert isinstance(argument, swig_paddle.Arguments)
assert isinstance(self.input_type, dp2.InputType)
if self.__mat__.dtype != numpy.float32:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

即使__mat__初始化成float32的类型，在numpy.append操作中，dtype还是有可能被修改成float64.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

什么情况下会中招？表现是啥

self.__mat__ = self.__mat__.astype(numpy.float32)
m = swig_paddle.Matrix.createDenseFromNumpy(self.__mat__, True, False)
argument.setSlotValue(self.pos, m)

Expand Down