Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/add_inference_lib_to_release #11455

Conversation

Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Jun 14, 2018

Add contrib/inference/

  • paddle_inference_api.h
  • libpaddle_inference_api.a

into dist.

The current output is

total 128M
-rwxr-xr-x 1 root root 2.5K Jun 14 01:36 engine.h
-rwxr-xr-x 1 root root 1.8K Jun 14 01:36 io.h
-rw-r--r-- 1 root root  86M Jun 14 01:36 libpaddle_fluid.a
-rwxr-xr-x 1 root root  43M Jun 14 01:36 libpaddle_fluid.so
-rw-r--r-- 1 root root 217K Jun 14 01:36 libpaddle_inference_api.a
-rwxr-xr-x 1 root root 3.7K Jun 14 01:36 paddle_inference_api.h

@Superjomn Superjomn changed the title update bugfix/add_inference_lib_to_release Jun 14, 2018
@Superjomn Superjomn requested a review from luotao1 June 14, 2018 01:46
@@ -150,9 +151,12 @@ copy(memory_lib
)

set(module "inference")
Copy link
Contributor

@luotao1 luotao1 Jun 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需要with_contrib开关来控制copy,不然off的时候会出错。
  2. copy到paddle/fluid/inference目录下么?能单独放到contrib/inference目录下么,和paddle代码目录保持统一。
    改成类似下面的如何?
if(WITH_CONTRIB)
   set(dst_dir "${FLUID_INSTALL_DIR}/contrib/inference")
   copy(contrib_inference_lib DEPS paddle_inference_api 
           SRCS ${contrib_dir}/${module}/paddle_inference_api.h 
           ${PADDLE_BINARY_DIR}/paddle/contrib/inference/libpaddle_inference_api.*
           DSTS ${dst_dir} ${dst_dir}
   )
endif()
   

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先放过去吧,这周应该也要 merge 回 fluid 目录了

@Superjomn Superjomn closed this Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants