-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tool for supervise python api #11562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. Do you have an example output?
module_str = '.'.join(file_name.split('/')[3:]) | ||
module_str = '.'.join(module_str.split('.')[:-1]) | ||
print module_str | ||
args = parse_args() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps we only need to parse_args once at the beginning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , it will be clearer
|
||
def check_api(module_str, dest_dir): | ||
'''get current api's info, | ||
then compare with info loaded from saved''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can put ``` at the next line.
Would be good to use the same code style as paddle-core's code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it!
output are as below: if api changed, error are as below: before: { |
oh, 想起来,于洋老师改了一版优雅版的交了~ |
resolve #11556