Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check return value of patchelf in setup.py.in #12000

Merged
merged 1 commit into from
Jul 6, 2018
Merged

check return value of patchelf in setup.py.in #12000

merged 1 commit into from
Jul 6, 2018

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jul 6, 2018

@luotao1 luotao1 requested a review from typhoonzero July 6, 2018 03:05
typhoonzero
typhoonzero approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@luotao1 luotao1 merged commit 89704d9 into PaddlePaddle:develop Jul 6, 2018
@luotao1 luotao1 deleted the mklml_rpath branch July 6, 2018 06:05
kuke pushed a commit to kuke/Paddle that referenced this pull request Aug 25, 2018
@luotao1
Merge pull request PaddlePaddle#12000 from luotao1/mklml_rpath
a1d86aa 
check return value of patchelf in setup.py.in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luotao1 @typhoonzero