Add python3.6 python3.7 support to manylinux Dockerfile #14460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
test=develop
test=develop
test=develop
typhoonzero
previously approved these changes
Nov 21, 2018
| @@ -36,17 +36,21 @@ RUN cd /opt && wget -q --no-check-certificate https://github.com/google/protobuf | |||
| tar xzf protobuf-cpp-3.1.0.tar.gz && \ | |||
| cd protobuf-3.1.0 && ./configure && make -j4 && make install && cd .. && rm -f protobuf-cpp-3.1.0.tar.gz | |||
|
|
|||
| RUN wget -O /root/requirements.txt https://raw.githubusercontent.com/PaddlePaddle/Paddle/develop/python/requirements.txt | |||
| RUN wget https://raw.githubusercontent.com/PaddlePaddle/Paddle/develop/python/requirements.txt -O /root/requirements.txt | |||
There was a problem hiding this comment.
what is this change for?
There was a problem hiding this comment.
Well this is a little trick for removing the requirements' cache
| make -j2 > /dev/null | ||
| make install > /dev/null | ||
| if [ $(lex_pyver $py_ver) -ge $(lex_pyver 3.7) ]; then | ||
| CFLAGS="-Wformat" ./configure --prefix=${prefix} --with-openssl=/usr/local/ssl --enable-shared $unicode_flags > /dev/null |
There was a problem hiding this comment.
better to add notes about why need to deal with version 3.7
There was a problem hiding this comment.
Thanks for reviewing, I added it now
… add_py36_py37_dockerfile
test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this issue, we should support python 3.6 and python 3.7 in manylinux1 Dockerfile