Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package sequenceAvgBackward #1713

Merged
merged 1 commit into from
Mar 29, 2017
Merged

package sequenceAvgBackward #1713

merged 1 commit into from
Mar 29, 2017

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Mar 28, 2017

考虑 #1608 ，为了使seqlastin, average, max三个layer具有一致性，方便后续添加stride参数。将average的backward封装成sequenceAvgBackward函数。

  • 补充gpu下sequenceAvgBackward函数的实现。
  • 在test_matrixCompare下，补充sequenceAvgBackward函数的单测。

@luotao1 luotao1 requested a review from qingqing01 March 28, 2017 09:32
qingqing01
qingqing01 approved these changes Mar 29, 2017
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

另外，如果后面改成function，可能还需要做一次改动~

@luotao1
Copy link
Contributor Author

luotao1 commented Mar 29, 2017

后面改成function的话，可以再改动。这里改动，是为了统一加stride参数。

@luotao1 luotao1 merged commit b1f16d2 into PaddlePaddle:develop Mar 29, 2017
@luotao1 luotao1 deleted the avg branch March 29, 2017 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luotao1 @qingqing01