-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create new api to indicate detect thread usage #18081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the description of this PR.
This PR solves 2 issues:
The solve method is to disable cache in this case, we extend EnableMKLDNN in AnaysisConfig, use parameter to control if cache is needed. |
test=develop
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are very core changes , have you run extensive performance tests to check if inference of our models (CAPI tests of our validation) is unharmed ?
@LeoZhao-Intel I just want to make sure that reusing is disabled only in situation when we expect it to be disabled. I will copy this PR branch to internal repo and run automatic tests. Results should be available tonight |
should be able to pass CI test, but it will fail if EnableMKLDNN(1) is called in multiple instances case and SetMkldnnthreadid() is not set properly, so as I said before it is just WA. Need re-factor whole stack including API. |
@LeoZhao-Intel Ok, performance (C-API) tests passed eg. no impact visible. My understanding is that you are still working on this PR ? |
this PR gonna be dropped since it impacts performance much and can't reach target, but some requirements may be leveraged into formal solution. e.g. support cache disabled case, use API to indicate scene. |
Thanks Leo for big efforts on this PR. The investigation in this PR had given us much insight of this issue. |
Closed. But some code will be cloned to a new PR from Leo. Similar as PR #18217 . |
This PR solves 2 issues:
The solve method is to disable cache in this case, we extend EnableMKLDNN in AnaysisConfig, use parameter to control if cache is needed.
related #17611