Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design doc: submit paddle job #2111

Merged
merged 1 commit into from
May 13, 2017
Merged

Design doc: submit paddle job #2111

merged 1 commit into from
May 13, 2017

Conversation

Yancey1989
Copy link
Contributor

@Yancey1989 Yancey1989 commented May 12, 2017 •
edited
Loading

here may better to view.

Related issue: #2019

@Yancey1989 Yancey1989 mentioned this pull request May 12, 2017
Closed
helinwang
helinwang approved these changes May 12, 2017
View reviewed changes
Copy link
Contributor

@helinwang helinwang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！另外，为何关了上一个PR（#1770 ）而新开了这个？要是一直在同一个PR讨论／修改，大家会容易follow up一点。

wangkuiyi
wangkuiyi approved these changes May 12, 2017
View reviewed changes
Copy link
Collaborator

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yancey1989
Copy link
Contributor Author

@helinwang 主要是因为上个PR的comments太多了，打开页面会加载很长时间。

@Yancey1989 Yancey1989 merged commit ae647bf into PaddlePaddle:develop May 13, 2017
@Yancey1989 Yancey1989 deleted the submit-job-doc branch May 13, 2017 02:55
heavengate pushed a commit to heavengate/Paddle that referenced this pull request Aug 16, 2021
@yghstill
fix MaskMatrixNMS register (PaddlePaddle#2111)
9a2651f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helinwang helinwang helinwang approved these changes

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

@gongweibao gongweibao Awaiting requested review from gongweibao

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yancey1989 @wangkuiyi @helinwang