Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rand API: remove out, device, stop_gradient; add name #25246

Merged
merged 5 commits into from
Jul 7, 2020
Merged

rand API: remove out, device, stop_gradient; add name #25246

merged 5 commits into from
Jul 7, 2020

Conversation

zhupengyang
Copy link
Contributor

@zhupengyang zhupengyang commented Jun 29, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

  • rand
    • API: remove out, devive, stop_gradient; add name
    • doc: remove description of out, device, stop_gradient; add description of name; modify code style to paddle.**
    • add unittest of cuda case
  • uniform_random
    • API: add name
    • doc: add description of name
  • gaussian_random
    • 修复报错信息的逻辑错误

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhupengyang zhupengyang reopened this Jun 29, 2020
@PaddlePaddle PaddlePaddle deleted a comment from paddle-bot-old bot Jun 30, 2020
@zhupengyang zhupengyang changed the title rand API: remove out, devive, stop_gradient; add name rand API: remove out, device, stop_gradient; add name Jun 30, 2020
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 3, 2020

Thanks for your contribution!
Please add test = develop in your commit message to trigger CI to ensure your PR can be merged.
See Paddle CI Manual for details.

wangchaochaohu
wangchaochaohu approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@wangchaochaohu wangchaochaohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swtkiwi
swtkiwi approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit eb3173e into PaddlePaddle:develop Jul 7, 2020
@zhupengyang zhupengyang deleted the rands branch July 7, 2020 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanxianghit lanxianghit lanxianghit approved these changes

@swtkiwi swtkiwi swtkiwi approved these changes

@wangchaochaohu wangchaochaohu wangchaochaohu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhupengyang @wangchaochaohu @swtkiwi @lanxianghit