Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine the full_like Op test=develop #25294

Merged
merged 15 commits into from
Jul 9, 2020
Merged

refine the full_like Op test=develop #25294

merged 15 commits into from
Jul 9, 2020

Conversation

wangchaochaohu
Copy link
Contributor

@wangchaochaohu wangchaochaohu commented Jul 1, 2020 •
edited
Loading

PR types

Function optimization

PR changes

Ops

Describe

refine the full_like API for 2.0

old

paddle.tensor.full_like(input, fill_value, out=None, dtype=None, device=None, stop_gradient=True, name=None)

new

 paddle.tensor.full_like(x, fill_value, dtype=None, name=None)

zhupengyang
zhupengyang reviewed Jul 7, 2020
View reviewed changes
python/paddle/fluid/tests/unittests/test_fill_any_like_op.py Outdated Show resolved Hide resolved
python/paddle/tensor/creation.py Outdated Show resolved Hide resolved
python/paddle/tensor/creation.py Outdated Show resolved Hide resolved
python/paddle/tensor/creation.py Outdated Show resolved Hide resolved
@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 7, 2020

Thanks for your contribution!
Please add test = develop in your commit message to trigger CI to ensure your PR can be merged.
See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 7, 2020

Thanks for your contribution!
Please add test = develop in your commit message to trigger CI to ensure your PR can be merged.
See Paddle CI Manual for details.

zhupengyang
zhupengyang previously approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wawltor
wawltor previously approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchaochaohu wangchaochaohu dismissed stale reviews from wawltor and zhupengyang via aa2d41b July 8, 2020 08:27
zhupengyang
zhupengyang previously approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@zhupengyang zhupengyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit reviewed Jul 8, 2020
View reviewed changes
python/paddle/tensor/creation.py Outdated
fill_value(bool|float|int|Variable): The value to fill the tensor with. Default value is 0.
Note: this value shouldn't exceed the range of the output data type.
dtype(np.dtype|core.VarDesc.VarType|str, optional): The data type of output. The data type can be one
of bool, float16, float32, float64, int32, int64 .The default value is None, which means the output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int64 .The default value

格式有问题，句点应该跟着前面的词

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

lanxianghit
lanxianghit approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swtkiwi
swtkiwi approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchaochaohu wangchaochaohu merged commit 090a331 into PaddlePaddle:develop Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanxianghit lanxianghit lanxianghit approved these changes

@swtkiwi swtkiwi swtkiwi approved these changes

@zhupengyang zhupengyang zhupengyang left review comments

@wawltor wawltor wawltor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangchaochaohu @wawltor @swtkiwi @lanxianghit @zhupengyang