Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable check_dygraph for mkldnn activation tests #25779

Conversation

sfraczek
Copy link
Contributor

@sfraczek sfraczek commented Jul 28, 2020

PR types

New features

PR changes

Others

Describe

Enable tests in dygraph mode for mkldnn activation ops. Override of test_check_output and test_check_grad is no longer needed.
It depends on other dygraph pull requests.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@sfraczek sfraczek added dygraph issues related to dygraph mode Intel labels Jul 28, 2020
wojtuss
wojtuss previously approved these changes Jul 29, 2020
@lidanqing-intel
Copy link
Contributor

@luotao1 Could you please help download PR_Windows_CI_OPENBLAS (Paddle Windows) now the old method does not work. Thanks a lot

@luotao1
Copy link
Contributor

luotao1 commented Aug 6, 2020

Paddle_Windows_PR_Windows_CI_OPENBLAS_6706.log
It seems random fail, I rerun it.

@grygielski
Copy link
Contributor

@luotao1 What about now, is it random fail again?

@luotao1
Copy link
Contributor

luotao1 commented Aug 7, 2020

I rerun again, the random build error of this windows machine is high than others.

@luotao1 luotao1 merged commit 4c9ddb3 into PaddlePaddle:develop Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dygraph issues related to dygraph mode Intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants