Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move dataset from paddfle.fluid to paddle.fleet #25887

Merged
merged 11 commits into from
Aug 6, 2020
Merged

move dataset from paddfle.fluid to paddle.fleet #25887

merged 11 commits into from
Aug 6, 2020

Conversation

xjqbest
Copy link
Contributor

@xjqbest xjqbest commented Aug 2, 2020 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

move paddle.fluid.dataset to paddle.fleet.dataset

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 2, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 2, 2020 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@fuyinno4 fuyinno4 self-requested a review August 6, 2020 01:43
fuyinno4
fuyinno4 previously approved these changes Aug 6, 2020
View reviewed changes
guru4elephant
guru4elephant approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@guru4elephant guru4elephant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xjqbest xjqbest changed the title move dataset to fleet move dataset from paddfle.fluid to paddle.fleet Aug 6, 2020
jzhang533
jzhang533 reviewed Aug 6, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a series of API's relocation.
you may need to annotate the apis in paddle.fluid.dataset as deprecated explicitly.
how to deprecate the apis planned to discontinue: #25912

raindrops2sea
raindrops2sea approved these changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Heeenrrry
Heeenrrry approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@Heeenrrry Heeenrrry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in an urgent review. for the deprecated apis, a new commit with annotation should be given later.

@fuyinno4 fuyinno4 merged commit 20c8432 into PaddlePaddle:develop Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 left review comments

@lanxianghit lanxianghit lanxianghit approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@fuyinno4 fuyinno4 fuyinno4 approved these changes

@guru4elephant guru4elephant guru4elephant approved these changes

@Heeenrrry Heeenrrry Heeenrrry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xjqbest @jzhang533 @Heeenrrry @guru4elephant @fuyinno4 @raindrops2sea @lanxianghit