Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_softmax and LogSoftmax: impl kernel and refind docs #26088

Merged
merged 15 commits into from
Aug 18, 2020
Merged

log_softmax and LogSoftmax: impl kernel and refind docs #26088

merged 15 commits into from
Aug 18, 2020

Conversation

zhupengyang
Copy link
Contributor

@zhupengyang zhupengyang commented Aug 10, 2020 •
edited
Loading

PR types

Others

PR changes

OPs

Describe

  • implement log_softmax kerel to improve performance
  • refind docs

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhupengyang zhupengyang force-pushed the logsoftmax branch 3 times, most recently from 98c8825 to 77affb4 Compare August 10, 2020 12:24
@CLAassistant
Copy link

CLAassistant commented Aug 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

hong19860320
hong19860320 previously approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hong19860320
hong19860320 previously approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hong19860320
hong19860320 approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@hong19860320 hong19860320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/paddle/fluid/tests/unittests/test_log_softmax.py Show resolved Hide resolved
@zhupengyang zhupengyang merged commit 586a6dd into PaddlePaddle:develop Aug 18, 2020
@zhupengyang zhupengyang deleted the logsoftmax branch August 18, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hong19860320 hong19860320 hong19860320 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhupengyang @CLAassistant @hong19860320